raising error when the surface is not completely embedded inside FFDS. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 64.61% 64.60% -0.01%
==========================================
Files 47 47
Lines 11954 11952 -2
==========================================
- Hits 7724 7722 -2
Misses 4230 4230
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
13 tasks
|
Please see my comments in #179 |
|
@marcomangano Yes, I am planning to address them next week or so.. probably I will get it done soon |
|
@ArshSaja any updates on this? |
I made some changes. I will push them soon when it is finalized. |
|
@ArshSaja do you still intend to finish this PR? Seems this has gone stale over the past year. |
We can draft this one. It needs more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DvGeo prints a warning when it cannot embed points. So that people understand not to proceed, this warning has to be strengthened. This PR will assist in identifying any such problems.
Expected time until merged
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable